Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes the Select unselect for object values #16062

Merged
merged 1 commit into from
Aug 4, 2021
Merged

fix: Fixes the Select unselect for object values #16062

merged 1 commit into from
Aug 4, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the Select unselect for object values.

@junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-04.at.11.06.10.AM.mov
Screen.Recording.2021-08-04.at.11.09.42.AM.mov

TESTING INSTRUCTIONS

See the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

geido
geido approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

villebro
villebro approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #16062 (397f1cc) into master (4cb79e5) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16062      +/-   ##
==========================================
- Coverage   76.90%   76.89%   -0.02%     
==========================================
  Files         995      995              
  Lines       52842    52848       +6     
  Branches     6709     6713       +4     
==========================================
- Hits        40640    40638       -2     
- Misses      11976    11984       +8     
  Partials      226      226
Flag Coverage Δ
javascript 71.29% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 72.39% <60.00%> (-2.04%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.53% <0.00%> (-0.36%) ⬇️
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 93.18% <0.00%> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.25% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...397f1cc. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 1917464 into apache:master Aug 4, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

@villebro villebro added the v1.3 label Aug 10, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
@michael-s-molina @villebro
fix: Fix the Select unselect for object values (#16062)
aec507d 
(cherry picked from commit 1917464)
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
@michael-s-molina
fix: Fix the Select unselect for object values (apache#16062)
d00a2c2 
(cherry picked from commit 1917464)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@michael-s-molina
fix: Fix the Select unselect for object values (apache#16062)
8b4b02b
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@michael-s-molina
fix: Fix the Select unselect for object values (apache#16062)
9fe284d 
(cherry picked from commit 1917464)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@michael-s-molina
fix: Fix the Select unselect for object values (apache#16062)
8309c1b
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina @villebro
fix: Fix the Select unselect for object values (apache#16062)
f376f92 
(cherry picked from commit 1917464)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
fix: Fix the Select unselect for object values (apache#16062)
d3bc961 
(cherry picked from commit 8a8a996)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/S v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michael-s-molina @rosemarie-chiu @villebro @geido @mistercrunch